feat(datepicker): add aria-* attrs and keyboard bindings to datepicker input #3542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
requested changes
Mar 10, 2017
|
|
||
| @Component({ | ||
| moduleId: module.id, | ||
| selector: 'md-datepicker-trigger, mat-datepicker-trigger', |
There was a problem hiding this comment.
I thought we renamed this to mdDatepickerToggle? Rebase error?
src/lib/input/input-container.ts
Outdated
| @@ -381,4 +383,8 @@ export class MdInputContainer implements AfterContentInit { | |||
|
|
|||
| this._mdInputChild.ariaDescribedby = ids.join(' '); | |||
| } | |||
|
|
|||
| getPopupConnectionElementRef(): ElementRef { | |||
There was a problem hiding this comment.
Didn't we decide to remove this?
src/lib/datepicker/datepicker.ts
Outdated
| @@ -27,6 +27,9 @@ import {MdDatepickerInput} from './datepicker-input'; | |||
| import {CalendarLocale} from '../core/datetime/calendar-locale'; | |||
|
|
|||
|
|
|||
| let datepickerUid = 0; | |||
There was a problem hiding this comment.
Add comment about what this is? We should also probably prefix with an underscore to be consistent with other counters.
|
comments addressed |
kara
added
pr: lgtm
action: merge
mmalerba
added a commit
that referenced
this pull request
Mar 17, 2017
…r input (#3542) * add aria-* attrs and keyboard bindings to datepicker input * fix rebase errors * added comment
mmalerba
added a commit
to mmalerba/components
that referenced
this pull request
Mar 28, 2017
…r input (angular#3542) * add aria-* attrs and keyboard bindings to datepicker input * fix rebase errors * added comment
mmalerba
added a commit
that referenced
this pull request
Apr 14, 2017
…r input (#3542) * add aria-* attrs and keyboard bindings to datepicker input * fix rebase errors * added comment
mmalerba
added a commit
that referenced
this pull request
Apr 20, 2017
…r input (#3542) * add aria-* attrs and keyboard bindings to datepicker input * fix rebase errors * added comment
mmalerba
added a commit
that referenced
this pull request
Apr 29, 2017
…r input (#3542) * add aria-* attrs and keyboard bindings to datepicker input * fix rebase errors * added comment
mmalerba
added a commit
that referenced
this pull request
May 5, 2017
…r input (#3542) * add aria-* attrs and keyboard bindings to datepicker input * fix rebase errors * added comment
mmalerba
added a commit
that referenced
this pull request
May 9, 2017
…r input (#3542) * add aria-* attrs and keyboard bindings to datepicker input * fix rebase errors * added comment
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.